46 lines
737 B
Markdown
46 lines
737 B
Markdown
# org/repo `#42` Improve transaction handling
|
|
|
|
## Review 42.1 (COMMENT)
|
|
> reviewer-a
|
|
|
|
### Comment 42.1.1
|
|
service/order.rs:87
|
|
reviewer-a:
|
|
```md
|
|
为什么要在循环里每次开启事务？
|
|
```
|
|
|
|
### Reply 42.1.1.1
|
|
service/order.rs:87
|
|
author:
|
|
```md
|
|
为了保证每个子任务互不影响。
|
|
```
|
|
|
|
## Review 42.2 (REQUEST_CHANGES)
|
|
> reviewer-b
|
|
|
|
### Comment 42.2.1
|
|
api/order.ts:15
|
|
reviewer-b:
|
|
```md
|
|
建议把 `createOrder(input)` 改成 `createOrder(ctx, input)`，否则审计信息拿不到。
|
|
```
|
|
|
|
## Review 42.3 (COMMENT)
|
|
> reviewer-c
|
|
|
|
### Comment 42.3.1
|
|
service/order.rs:120
|
|
reviewer-c:
|
|
```md
|
|
这里的缓存失效策略是不是太激进了？
|
|
```
|
|
|
|
### Reply 42.3.1.1
|
|
service/order.rs:120
|
|
author:
|
|
```md
|
|
按之前的约定处理。
|
|
```
|